Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timeout issues aws_route_table_association #30755

Merged
merged 5 commits into from
Apr 18, 2023
Merged

fix timeout issues aws_route_table_association #30755

merged 5 commits into from
Apr 18, 2023

Conversation

meetreks
Copy link
Contributor

Description

Added timeout parameters which enable users to add custom wait times to cater for any timeouts due to the route table association ec2 operation.

Relations

Closes #28355

References

The EC2 API is eventually consistent. Kindly refer to this documentation for more details - https://docs.aws.amazon.com/AWSEC2/latest/APIReference/query-api-troubleshooting.html#eventual-consistency

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS=TestAccVPCRouteTableAssociation_Subnet_basic
:~/terraform-provider-aws (b-aws_route_table_association) $ make testacc PKG=ec2 TESTS=TestAccVPCRouteTableAssociation_Subnet_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableAssociation_Subnet_basic'  -timeout 180m
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (19.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        19.983s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 16, 2023
@ewbankkit ewbankkit added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 17, 2023
@ewbankkit ewbankkit self-assigned this Apr 17, 2023
ewbankkit
ewbankkit approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCRouteTableAssociation_\|TestAccVPCMainRouteTableAssociation_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCRouteTableAssociation_\|TestAccVPCMainRouteTableAssociation_ -timeout 180m
=== RUN   TestAccVPCMainRouteTableAssociation_basic
=== PAUSE TestAccVPCMainRouteTableAssociation_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_changeRouteTable
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_changeRouteTable
=== RUN   TestAccVPCRouteTableAssociation_Gateway_basic
=== PAUSE TestAccVPCRouteTableAssociation_Gateway_basic
=== RUN   TestAccVPCRouteTableAssociation_Gateway_changeRouteTable
=== PAUSE TestAccVPCRouteTableAssociation_Gateway_changeRouteTable
=== RUN   TestAccVPCRouteTableAssociation_disappears
=== PAUSE TestAccVPCRouteTableAssociation_disappears
=== CONT  TestAccVPCMainRouteTableAssociation_basic
=== CONT  TestAccVPCRouteTableAssociation_Gateway_basic
=== CONT  TestAccVPCRouteTableAssociation_disappears
--- PASS: TestAccVPCRouteTableAssociation_disappears (27.36s)
=== CONT  TestAccVPCRouteTableAssociation_Gateway_changeRouteTable
--- PASS: TestAccVPCRouteTableAssociation_Gateway_basic (33.03s)
=== CONT  TestAccVPCRouteTableAssociation_Subnet_changeRouteTable
--- PASS: TestAccVPCMainRouteTableAssociation_basic (48.97s)
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (33.17s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_changeRouteTable (49.49s)
--- PASS: TestAccVPCRouteTableAssociation_Gateway_changeRouteTable (55.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	90.860s

@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8fa7254 into hashicorp:main Apr 18, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 18, 2023
@meetreks meetreks deleted the b-aws_route_table_association branch April 18, 2023 15:54
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.64.0
2 participants
@meetreks @ewbankkit